summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--modules/caddytls/tls.go7
1 files changed, 5 insertions, 2 deletions
diff --git a/modules/caddytls/tls.go b/modules/caddytls/tls.go
index fc5f2ac..2e532ed 100644
--- a/modules/caddytls/tls.go
+++ b/modules/caddytls/tls.go
@@ -185,9 +185,12 @@ func (t *TLS) Provision(ctx caddy.Context) error {
onDemandRateLimiter.SetWindow(0)
}
- // run replacer on ask URL (for environment variables)
+ // run replacer on ask URL (for environment variables) -- return errors to prevent surprises (#5036)
if t.Automation != nil && t.Automation.OnDemand != nil && t.Automation.OnDemand.Ask != "" {
- t.Automation.OnDemand.Ask = repl.ReplaceAll(t.Automation.OnDemand.Ask, "")
+ t.Automation.OnDemand.Ask, err = repl.ReplaceOrErr(t.Automation.OnDemand.Ask, true, true)
+ if err != nil {
+ return fmt.Errorf("preparing 'ask' endpoint: %v", err)
+ }
}
// load manual/static (unmanaged) certificates - we do this in