summaryrefslogtreecommitdiff
path: root/modules/caddytls/acmeissuer.go
diff options
context:
space:
mode:
authorMatthew Holt <mholt@users.noreply.github.com>2020-03-13 19:14:49 -0600
committerMatthew Holt <mholt@users.noreply.github.com>2020-03-13 19:14:49 -0600
commit7a4548c5823e85bab0a2e2f40a3ea00f64ce8552 (patch)
treed689258be31245bd115e7a3140c585781c2371c5 /modules/caddytls/acmeissuer.go
parent6cbd93736fcd2e202fb4d5cfc3f9dd45b6121b0b (diff)
Some hotfixes for beta 16
Diffstat (limited to 'modules/caddytls/acmeissuer.go')
-rw-r--r--modules/caddytls/acmeissuer.go6
1 files changed, 5 insertions, 1 deletions
diff --git a/modules/caddytls/acmeissuer.go b/modules/caddytls/acmeissuer.go
index f108d72..53638fe 100644
--- a/modules/caddytls/acmeissuer.go
+++ b/modules/caddytls/acmeissuer.go
@@ -144,6 +144,10 @@ func (m *ACMEIssuer) SetConfig(cfg *certmagic.Config) {
m.magic = cfg
}
+// TODO: I kind of hate how each call to these methods needs to
+// make a new ACME manager to fill in defaults before using; can
+// we find the right place to do that just once and then re-use?
+
// PreCheck implements the certmagic.PreChecker interface.
func (m *ACMEIssuer) PreCheck(names []string, interactive bool) error {
return certmagic.NewACMEManager(m.magic, m.template).PreCheck(names, interactive)
@@ -156,7 +160,7 @@ func (m *ACMEIssuer) Issue(ctx context.Context, csr *x509.CertificateRequest) (*
// IssuerKey returns the unique issuer key for the configured CA endpoint.
func (m *ACMEIssuer) IssuerKey() string {
- return m.template.IssuerKey() // does not need storage and cache
+ return certmagic.NewACMEManager(m.magic, m.template).IssuerKey()
}
// Revoke revokes the given certificate.