summaryrefslogtreecommitdiff
path: root/modules/caddypki
diff options
context:
space:
mode:
authorMatthew Holt <mholt@users.noreply.github.com>2020-03-20 20:25:46 -0600
committerMatthew Holt <mholt@users.noreply.github.com>2020-03-20 20:25:46 -0600
commitd692d503a3d327d54c82bceab48bb1de07bb3c3d (patch)
tree82d4442c9188b361fdf20b90a453e6d65a96a80b /modules/caddypki
parent3c1def243020a3897121d4c5badf07ed45d2397d (diff)
tls/http: Fix auto-HTTPS logic w/rt default issuers (fixes #3164)
The comments in the code should explain the new logic thoroughly. The basic problem for the issue was that we were overriding a catch-all automation policy's explicitly-configured issuer with our own, for names that we thought looked like public names. In other words, one could configure an internal issuer for all names, but then our auto HTTPS would create a new policy for public-looking names that uses the default ACME issuer, because we assume public<==>ACME and nonpublic<==>Internal, but that is not always the case. The new logic still assumes nonpublic<==>Internal (on catch-all policies only), but no longer assumes that public-looking names always use an ACME issuer. Also fix a bug where HTTPPort and HTTPSPort from the HTTP app weren't being carried through to ACME issuers properly. It required a bit of refactoring.
Diffstat (limited to 'modules/caddypki')
0 files changed, 0 insertions, 0 deletions