diff options
author | Matthew Holt <mholt@users.noreply.github.com> | 2021-12-13 16:13:29 -0700 |
---|---|---|
committer | Matthew Holt <mholt@users.noreply.github.com> | 2021-12-13 16:13:38 -0700 |
commit | a1c41210d34c629c3b5cdbdca74c540fde752aad (patch) | |
tree | 3889632b4fe919878b78b4b59f9c35635e239641 /modules/caddypki | |
parent | ecac03cdcb6cceae743aac16faca7f32e5da1607 (diff) |
caddypki: Minor tweak, don't use context pointer
Diffstat (limited to 'modules/caddypki')
-rw-r--r-- | modules/caddypki/acmeserver/acmeserver.go | 2 | ||||
-rw-r--r-- | modules/caddypki/pki.go | 10 |
2 files changed, 4 insertions, 8 deletions
diff --git a/modules/caddypki/acmeserver/acmeserver.go b/modules/caddypki/acmeserver/acmeserver.go index 388aa52..ff021b4 100644 --- a/modules/caddypki/acmeserver/acmeserver.go +++ b/modules/caddypki/acmeserver/acmeserver.go @@ -102,7 +102,7 @@ func (ash *Handler) Provision(ctx caddy.Context) error { return err } pkiApp := appModule.(*caddypki.PKI) - ca, err := pkiApp.GetCA(ash.CA, &ctx) + ca, err := pkiApp.GetCA(ctx, ash.CA) if err != nil { return err } diff --git a/modules/caddypki/pki.go b/modules/caddypki/pki.go index f391fda..c19bd0f 100644 --- a/modules/caddypki/pki.go +++ b/modules/caddypki/pki.go @@ -121,9 +121,8 @@ func (p *PKI) Stop() error { // GetCA retrieves a CA by ID. If the ID is the default // CA ID, and it hasn't been provisioned yet, it will -// be provisioned. The context must be passed if this -// is called from a module's Provision(). -func (p *PKI) GetCA(id string, ctx *caddy.Context) (*CA, error) { +// be provisioned. +func (p *PKI) GetCA(ctx caddy.Context, id string) (*CA, error) { ca, ok := p.CAs[id] if !ok { // for anything other than the default CA ID, error out if it wasn't configured @@ -132,10 +131,7 @@ func (p *PKI) GetCA(id string, ctx *caddy.Context) (*CA, error) { } // for the default CA ID, provision it, because we want it to "just work" - if ctx == nil { - return nil, fmt.Errorf("cannot provision default CA without the context") - } - err := p.ProvisionDefaultCA(*ctx) + err := p.ProvisionDefaultCA(ctx) if err != nil { return nil, fmt.Errorf("failed to provision default CA: %s", err) } |