Refactor Caddyfile adapter and module registration

Use piles from which to draw config values.

Module values can return their name, so now we can do two-way mapping
from value to name and name to value; whereas before we could only map
name to value. This was problematic with the Caddyfile adapter since
it receives values and needs to know the name to put in the config.

1 files changed, 18 insertions, 8 deletions

diff --git a/modules/caddyhttp/vars.go b/modules/caddyhttp/vars.go
index f74556a..bbd4568 100644
--- a/modules/caddyhttp/vars.go
+++ b/modules/caddyhttp/vars.go
@@ -21,20 +21,22 @@ import (
 )
 
 func init() {
-	caddy.RegisterModule(caddy.Module{
-		Name: "http.handlers.vars",
-		New:  func() interface{} { return new(VarsMiddleware) },
-	})
-	caddy.RegisterModule(caddy.Module{
-		Name: "http.matchers.vars",
-		New:  func() interface{} { return new(VarsMiddleware) },
-	})
+	caddy.RegisterModule(VarsMiddleware{})
+	caddy.RegisterModule(VarsMatcher{})
 }
 
 // VarsMiddleware is an HTTP middleware which sets variables
 // in the context, mainly for use by placeholders.
 type VarsMiddleware map[string]string
 
+// CaddyModule returns the Caddy module information.
+func (VarsMiddleware) CaddyModule() caddy.ModuleInfo {
+	return caddy.ModuleInfo{
+		Name: "http.handlers.vars",
+		New:  func() caddy.Module { return new(VarsMiddleware) },
+	}
+}
+
 func (t VarsMiddleware) ServeHTTP(w http.ResponseWriter, r *http.Request, next Handler) error {
 	vars := r.Context().Value(VarCtxKey).(map[string]interface{})
 	repl := r.Context().Value(caddy.ReplacerCtxKey).(caddy.Replacer)
@@ -50,6 +52,14 @@ func (t VarsMiddleware) ServeHTTP(w http.ResponseWriter, r *http.Request, next H
 // requests based on variables in the context.
 type VarsMatcher map[string]string
 
+// CaddyModule returns the Caddy module information.
+func (VarsMatcher) CaddyModule() caddy.ModuleInfo {
+	return caddy.ModuleInfo{
+		Name: "http.matchers.vars",
+		New:  func() caddy.Module { return new(VarsMatcher) },
+	}
+}
+
 // Match matches a request based on variables in the context.
 func (m VarsMatcher) Match(r *http.Request) bool {
 	vars := r.Context().Value(VarCtxKey).(map[string]string)