diff options
| author | Matthew Holt <mholt@users.noreply.github.com> | 2019-07-09 12:58:39 -0600 |
|---|---|---|
| committer | Matthew Holt <mholt@users.noreply.github.com> | 2019-07-09 12:58:39 -0600 |
| commit | 4a3a418156e25aae17659142a4bf9259d7702c44 (patch) | |
| tree | 559461c6504b7c1be38e0ddfbf0793b473ef8d66 /modules/caddyhttp/staticresp_test.go | |
| parent | 6dfba5fda82e216cffb117a62fcefbe61cd25a34 (diff) | |
Flatten HTTP handler config (#2662)
Differentiating middleware and responders has one benefit, namely that
it's clear which module provides the response, but even then it's not
a great advantage. Linear handler config makes a little more sense,
giving greater flexibility and simplifying the core a bit, even though
it's slightly awkward that handlers which are responders may not use
the 'next' handler that is passed in at all.
Diffstat (limited to 'modules/caddyhttp/staticresp_test.go')
| -rw-r--r-- | modules/caddyhttp/staticresp_test.go | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/modules/caddyhttp/staticresp_test.go b/modules/caddyhttp/staticresp_test.go index b518bb0..111e4f3 100644 --- a/modules/caddyhttp/staticresp_test.go +++ b/modules/caddyhttp/staticresp_test.go @@ -19,6 +19,7 @@ import ( "io/ioutil" "net/http" "net/http/httptest" + "strconv" "testing" "github.com/caddyserver/caddy/v2" @@ -29,7 +30,7 @@ func TestStaticResponseHandler(t *testing.T) { w := httptest.NewRecorder() s := Static{ - StatusCode: http.StatusNotFound, + StatusCode: strconv.Itoa(http.StatusNotFound), Headers: http.Header{ "X-Test": []string{"Testing"}, }, @@ -37,7 +38,7 @@ func TestStaticResponseHandler(t *testing.T) { Close: true, } - err := s.ServeHTTP(w, r) + err := s.ServeHTTP(w, r, nil) if err != nil { t.Errorf("did not expect an error, but got: %v", err) } |