diff options
author | Matthew Holt <mholt@users.noreply.github.com> | 2019-05-23 14:42:14 -0600 |
---|---|---|
committer | Matthew Holt <mholt@users.noreply.github.com> | 2019-05-23 14:42:14 -0600 |
commit | 5a4a1421de9cc3a9d5aba9e48c195030cc24f576 (patch) | |
tree | c0d661f4ddf899af32765ac8ffaeebf97a0fd50c /modules/caddyhttp/server.go | |
parent | 34a25dd5580948ff5b83843b81e72bda1b133189 (diff) |
Fix error handling and matching catch-all routes
Diffstat (limited to 'modules/caddyhttp/server.go')
-rw-r--r-- | modules/caddyhttp/server.go | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/modules/caddyhttp/server.go b/modules/caddyhttp/server.go index 7b14ffa..4a1aafd 100644 --- a/modules/caddyhttp/server.go +++ b/modules/caddyhttp/server.go @@ -65,19 +65,19 @@ func (s *Server) ServeHTTP(w http.ResponseWriter, r *http.Request) { repl.Set("http.error.id", handlerErr.ID) } - if len(s.Errors.Routes) == 0 { - // TODO: polish the default error handling - log.Printf("[ERROR] Handler: %s", err) - if handlerErr, ok := err.(HandlerError); ok { - w.WriteHeader(handlerErr.StatusCode) - } - } else { + if s.Errors != nil && len(s.Errors.Routes) > 0 { errStack, w := s.Errors.Routes.BuildCompositeRoute(w, r) err := s.executeCompositeRoute(w, r, errStack) if err != nil { // TODO: what should we do if the error handler has an error? log.Printf("[ERROR] handling error: %v", err) } + } else { + // TODO: polish the default error handling + log.Printf("[ERROR] Handler: %s", err) + if handlerErr, ok := err.(HandlerError); ok { + w.WriteHeader(handlerErr.StatusCode) + } } } } |