diff options
| author | Francis Lavoie <lavofr@gmail.com> | 2023-08-02 16:03:26 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-08-02 20:03:26 +0000 |
| commit | cd486c25d168caf58f4b6fe5d3252df9432901ec (patch) | |
| tree | 1c444017467ff3339e5321429eb2c82d37fbf414 /modules/caddyhttp/reverseproxy/streaming_test.go | |
| parent | e198c605bd68f4b3630e5fa1ae9f7ca5cac1a7d9 (diff) | |
caddyhttp: Make use of `http.ResponseController` (#5654)
* caddyhttp: Make use of http.ResponseController
Also syncs the reverseproxy implementation with stdlib's which now uses ResponseController as well https://github.com/golang/go/commit/2449bbb5e614954ce9e99c8a481ea2ee73d72d61
* Enable full-duplex for HTTP/1.1
* Appease linter
* Add warning for builds with Go 1.20, so it's less surprising to users
* Improved godoc for EnableFullDuplex, copied text from stdlib
* Only wrap in encode if not already wrapped
Diffstat (limited to 'modules/caddyhttp/reverseproxy/streaming_test.go')
| -rw-r--r-- | modules/caddyhttp/reverseproxy/streaming_test.go | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/modules/caddyhttp/reverseproxy/streaming_test.go b/modules/caddyhttp/reverseproxy/streaming_test.go index 4ed1f1e..919538f 100644 --- a/modules/caddyhttp/reverseproxy/streaming_test.go +++ b/modules/caddyhttp/reverseproxy/streaming_test.go @@ -2,6 +2,7 @@ package reverseproxy import ( "bytes" + "net/http/httptest" "strings" "testing" ) @@ -13,12 +14,15 @@ func TestHandlerCopyResponse(t *testing.T) { strings.Repeat("a", defaultBufferSize), strings.Repeat("123456789 123456789 123456789 12", 3000), } + dst := bytes.NewBuffer(nil) + recorder := httptest.NewRecorder() + recorder.Body = dst for _, d := range testdata { src := bytes.NewBuffer([]byte(d)) dst.Reset() - err := h.copyResponse(dst, src, 0) + err := h.copyResponse(recorder, src, 0) if err != nil { t.Errorf("failed with error: %v", err) } |