diff options
author | Francis Lavoie <lavofr@gmail.com> | 2021-08-26 16:31:55 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-08-26 14:31:55 -0600 |
commit | 403732c433b816409e3525a9f49b4cc90abc2486 (patch) | |
tree | 9c017f8ab0e01c907ae71bc6c76bb2cdebc39d42 /modules/caddyhttp/caddyhttp_test.go | |
parent | f6d5ec2fd68c2b9ae3104c0e2650b37f07a552e1 (diff) |
httpcaddyfile: Reorder some directives (#4311)
We realized we made some mistakes with the directive ordering, so we're making some minor adjustments.
`abort` and `error` don't really make sense to be after other handler directives, because you would expect to be able to "fail-fast" and throw an error before falling through to some `file_server` or `respond` typically. So we're moving them up to just before `respond`, i.e. before the common handler directives.
This is also more consistent with our existing examples in the docs, which actually didn't work due to the directive ordering. See https://caddyserver.com/docs/caddyfile/directives/error#examples
Also, `push` doesn't quite make sense to be after `handle`/`route`, since its job is to read from response headers to push additional resources if necessary, and `handle`/`route` may be terminal so push would not be reached if it was declared outside those. And also, it would make sense to be _before_ `templates` because a template _could_ add a `Link` header to the response dynamically.
Diffstat (limited to 'modules/caddyhttp/caddyhttp_test.go')
0 files changed, 0 insertions, 0 deletions