| Age | Commit message (Collapse) | Author |
|---|
|
while i was timing the performance issue, i noticed that there was lots
of random redrawing going on.
turns out there were coming from here; if someone presses CTRL/ALT etc
without pressing anything else, nothing will be inserted, so nothing
will change. but the code will `break`, go down and do a needless redraw.
this patch changes it to simply return if the keypress iscntrl()
also avoid potential UB by casting *buf into an unsigned char.
|
|
`items` itself is not checked for NULL as calling free on NULL is defined to be
a no-op.
|
|
a massive amount of time inside readstdin() is spent trying to get the
max input width and then put it into inputw, only for it to get clamped
down to mw/3 inside setup().
it makes more sense to calculate inputw inside setup() once we have mw
available. similar to the last patch, i see noticeable startup
performance improvement:
before -> after
160ms -> 60ms
additionally this will take fallback fonts into account compared to the
previous version, so it's not only more performant but also more correct.
|
|
this replaces inefficient pattern of `MIN(TEXTW(..), n)` with
drw_fontset_getwidth_clamp() instead, which is far more efficient when
we only want up to a certain width.
dumping a decently sized (unicode) emoji file into dmenu, I see the
startup time drop significantly with this patch.
before -> after
360ms -> 160ms
this should also noticeably improve input latency (responsiveness) given
that calcoffsets() and drawmenu() are pretty hot functions.
|
|
Reported by Prathu Baronia <prathu.baronia@praton.me>, patch slightly changed.
Thanks!
|
|
|
|
... compared to the old cistrstr().
Thanks for the feedback!
|
|
|
|
The keypad Enter key was already supported. On some keyboard layouts like my
laptop the page-up and page-down key is more comfortable to use.
This adds a few lines but no complexity.
|
|
dmenu will not handle IME support (st will, atleast for now).
revert parts of commit 377bd37e212b1ec4c03a481245603c6560d0be22
this commit also broke input focus.
|
|
die() already prints a newline.
|
|
for example when IME variables are set, but the program is not started (yet).
|
|
|
|
If stdin is a tty and dmenu is ran with the fast option then it's
impossible to close stdin because the keyboard is already grabbed.
|
|
this is the proper idiom
|
|
feedback from Klemens, thanks
|
|
|
|
|
|
Thanks to nzl <uruabi@gmail.com> for the patch!
|
|
|
|
Mod1+b/^Left and Mod1+f/^Right
|
|
Reported by Jochen Sprickerhof, thanks!
Applied patch with minor change (only initialize `i` for XINERAMA).
|
|
loop outside directive
|
|
|
|
this makes it slightly easier to add colors to schemes.
|
|
WM_CLASS is a standard ICCCM property which is used to identify windows.
Window managers and compositors use it to allow per-application
configurable behavior.
|
|
This reverts commit 09d0a36e0370f7ca9bdb171bf93c5ac3131c5a92.
Using strncmp with the length of the user input turns it into a prefix
match rather than an exact match as it's supposed to be.
|
|
|
|
|
|
|
|
|
|
for example: dmenu -m '-9001'
|
|
This reverts commit a4053bc4e403ae57343f43b7e363a0911bba5a3a.
My bad, was working on the wrong branch and accidently pushed it...
*facepalm*
|
|
When the input text fully matches a single item, do not draw the item
and highlight the input text to show that it matches an item in
opposition to regular input text not matching anything.
|
|
Without this, we discard the item if it's longer than assigned width
instead of truncating it.
|
|
|
|
- extract drawitem function (code deduplication)
- fix bug where inputw was not correctly calculated from the widest item, but
just from the one with the longest strlen() which is not the same. It's better
now, but does not account for fallback fonts, since it would be too slow to
calculate all the correct item widths on startup.
- minor code style fixes (indentation, useless line breaks)
|
|
Let the user configure word boundaries other than ' ', only works with
the portable character set.
|
|
|
|
This was always broken.
Reproduce:
focus client on second monitor, spawn dmenu with -m 0.
Result:
Old wrong behaviour: dmenu spawns on second monitor (focused client).
Now: dmenu spawns on specified monitor (first).
|
|
this makes it slightly easier to add custom schemes aswell
|
|
just compare the size of the input string
|
|
look for exact matches comparing the user input against the item text
|
|
from Joshua Lloret on the ML:
"attached is a small patch to enable pasting from clipboard, as well as primary.
It seems like there was already code in there to allow this, but since there was never any case to match the upper case 'Y', that inline if would always evaluate to false."
|
|
|
|
|
|
Adds clarity. Typedefs for structs are definitely a discussion matter,
but there's no reason to hide a simple data-structure behind a
meaningless typedef.
|
|
|
|
|
|
- move main to bottom, usage above main.
- dont use variable names with function prototypes.
- space before if, for, while, etc: 'if(' -> 'if ('.
this makes the code-style more consistent
|
