From f15f0d5839479f8511621b88fa4bdcca3b89cc32 Mon Sep 17 00:00:00 2001
From: Matthew Holt <mholt@users.noreply.github.com>
Date: Sat, 14 Sep 2019 18:05:45 -0600
Subject: Eliminate some TODOs

---
 modules/caddytls/acmemanager.go    | 4 ++--
 modules/caddytls/connpolicy.go     | 4 ++--
 modules/caddytls/sessiontickets.go | 2 +-
 modules/caddytls/tls.go            | 4 ++--
 4 files changed, 7 insertions(+), 7 deletions(-)

(limited to 'modules/caddytls')

diff --git a/modules/caddytls/acmemanager.go b/modules/caddytls/acmemanager.go
index 0482ce3..f9a6409 100644
--- a/modules/caddytls/acmemanager.go
+++ b/modules/caddytls/acmemanager.go
@@ -74,7 +74,7 @@ func (m *ACMEManagerMaker) Provision(ctx caddy.Context) error {
 			return fmt.Errorf("loading DNS provider module: %s", err)
 		}
 		m.Challenges.DNS = val.(challenge.Provider)
-		m.Challenges.DNSRaw = nil // allow GC to deallocate - TODO: Does this help?
+		m.Challenges.DNSRaw = nil // allow GC to deallocate
 	}
 
 	// policy-specific storage implementation
@@ -88,7 +88,7 @@ func (m *ACMEManagerMaker) Provision(ctx caddy.Context) error {
 			return fmt.Errorf("creating TLS storage configuration: %v", err)
 		}
 		m.storage = cmStorage
-		m.Storage = nil // allow GC to deallocate - TODO: Does this help?
+		m.Storage = nil // allow GC to deallocate
 	}
 
 	return nil
diff --git a/modules/caddytls/connpolicy.go b/modules/caddytls/connpolicy.go
index c952369..7d86308 100644
--- a/modules/caddytls/connpolicy.go
+++ b/modules/caddytls/connpolicy.go
@@ -46,7 +46,7 @@ func (cp ConnectionPolicies) TLSConfig(ctx caddy.Context) (*tls.Config, error) {
 			}
 			cp[i].matchers = append(cp[i].matchers, val.(ConnectionMatcher))
 		}
-		cp[i].Matchers = nil // allow GC to deallocate - TODO: Does this help?
+		cp[i].Matchers = nil // allow GC to deallocate
 
 		// certificate selector
 		if pol.CertSelection != nil {
@@ -55,7 +55,7 @@ func (cp ConnectionPolicies) TLSConfig(ctx caddy.Context) (*tls.Config, error) {
 				return nil, fmt.Errorf("loading certificate selection module: %s", err)
 			}
 			cp[i].certSelector = val.(certmagic.CertificateSelector)
-			cp[i].CertSelection = nil // allow GC to deallocate - TODO: Does this help?
+			cp[i].CertSelection = nil // allow GC to deallocate
 		}
 	}
 
diff --git a/modules/caddytls/sessiontickets.go b/modules/caddytls/sessiontickets.go
index 2eb0773..6ca921d 100644
--- a/modules/caddytls/sessiontickets.go
+++ b/modules/caddytls/sessiontickets.go
@@ -62,7 +62,7 @@ func (s *SessionTicketService) provision(ctx caddy.Context) error {
 		return fmt.Errorf("loading TLS session ticket ephemeral keys provider module: %s", err)
 	}
 	s.keySource = val.(STEKProvider)
-	s.KeySource = nil // allow GC to deallocate - TODO: Does this help?
+	s.KeySource = nil // allow GC to deallocate
 
 	// if session tickets or just rotation are
 	// disabled, no need to start service
diff --git a/modules/caddytls/tls.go b/modules/caddytls/tls.go
index 99d3a5f..df4631c 100644
--- a/modules/caddytls/tls.go
+++ b/modules/caddytls/tls.go
@@ -71,7 +71,7 @@ func (t *TLS) Provision(ctx caddy.Context) error {
 			return fmt.Errorf("loading TLS automation management module: %s", err)
 		}
 		t.Automation.Policies[i].Management = val.(ManagerMaker)
-		t.Automation.Policies[i].ManagementRaw = nil // allow GC to deallocate - TODO: Does this help?
+		t.Automation.Policies[i].ManagementRaw = nil // allow GC to deallocate
 	}
 
 	// certificate loaders
@@ -138,7 +138,7 @@ func (t *TLS) Start() error {
 			return fmt.Errorf("automate: managing %v: %v", names, err)
 		}
 	}
-	t.Certificates = nil // allow GC to deallocate - TODO: Does this help?
+	t.Certificates = nil // allow GC to deallocate
 
 	return nil
 }
-- 
cgit v1.2.3