Age | Commit message (Collapse) | Author | |
---|---|---|---|
2020-08-07 | reverseproxy: Minor fixes and cleanup | Matthew Holt | |
Now use context cancellation to stop active health checker, which is simpler than and just as effective as using a separate stop channel. | |||
2020-05-26 | reverseproxy: Fix https active health checks #3450 (#3451) | AndyBan | |
2020-05-12 | all: Recover from panics in goroutines | Matthew Holt | |
2020-05-01 | reverseproxy: Remove circuitbreaker module (see #3331) | Matthew Holt | |
Moving to https://github.com/caddyserver/circuitbreaker Nobody was using it anyway -- it works well, but something got fumbled in a refactoring *months* ago. Turns out that we forgot the interface guards AND botched a method name (my bad) - Ok() should have been OK(). So it would always have thrown a runtime panic if it tried to be loaded. The module itself works well, but obviously nobody used it because nobody reported the error. Fixing this while we move it to the new repo. Removing this removes the last Bazaar/Launchpad dependency (I think). | |||
2020-02-23 | reverse_proxy: Health checks: Don't cross the streams | Matthew Holt | |
Fixes https://caddy.community/t/v2-health-checks-are-going-to-the-wrong-upstream/7084?u=matt ... I think | |||
2020-01-09 | http: Change routes to sequential matcher evaluation (#2967) | Matt Holt | |
Previously, all matchers in a route would be evaluated before any handlers were executed, and a composite route of the matching routes would be created. This made rewrites especially tricky, since the only way to defer later matchers' evaluation was to wrap them in a subroute, or to invoke a "rehandle" which often caused bugs. Instead, this new sequential design evaluates each route's matchers then its handlers in lock-step; matcher-handlers-matcher-handlers... If the first matching route consists of a rewrite, then the second route will be evaluated against the rewritten request, rather than the original one, and so on. This should do away with any need for rehandling. I've also taken this opportunity to avoid adding new values to the request context in the handler chain, as this creates a copy of the Request struct, which may possibly lead to bugs like it has in the past (see PR #1542, PR #1481, and maybe issue #2463). We now add all the expected context values in the top-level handler at the server, then any new values can be added to the variable table via the VarsCtxKey context key, or just the GetVar/SetVar functions. In particular, we are using this facility to convey dial information in the reverse proxy. Had to be careful in one place as the middleware compilation logic has changed, and moved a bit. We no longer compile a middleware chain per- request; instead, we can compile it at provision-time, and defer only the evaluation of matchers to request-time, which should slightly improve performance. Doing this, however, we take advantage of multiple function closures, and we also changed the use of HandlerFunc (function pointer) to Handler (interface)... this led to a situation where, if we aren't careful, allows one request routed a certain way to permanently change the "next" handler for all/most other requests! We avoid this by making a copy of the interface value (which is a lightweight pointer copy) and using exclusively that within our wrapped handlers. This way, the original stack frame is preserved in a "read-only" fashion. The comments in the code describe this phenomenon. This may very well be a breaking change for some configurations, however I do not expect it to impact many people. I will make it clear in the release notes that this change has occurred. | |||
2019-12-23 | Improve godocs all around | Matthew Holt | |
These will be used in the new automated documentation system | |||
2019-12-06 | Use "IsUnixNetwork" function instead of repeating the logic | Matthew Holt | |
2019-11-11 | core: Use port ranges to avoid OOM with bad inputs (#2859) | Mohammed Al Sahaf | |
* fix OOM issue caught by fuzzing * use ParsedAddress as the struct name for the result of ParseNetworkAddress * simplify code using the ParsedAddress type * minor cleanups | |||
2019-10-29 | reverse_proxy: Structured logs | Matthew Holt | |
2019-10-11 | reverse_proxy: Allow dynamic backends (closes #990 and #1539) | Matthew Holt | |
This PR enables the use of placeholders in an upstream's Dial address. A Dial address must represent precisely one socket after replacements. See also #998 and #1639. | |||
2019-10-04 | reverse_proxy: Configurable request headers on active health checks | Matthew Holt | |
See https://caddy.community/t/health-check-user-agent/6309 | |||
2019-09-14 | reverse_proxy: Ability to mutate headers; set upstream placeholders | Matthew Holt | |
2019-09-05 | Reconcile upstream dial addresses and request host/URL information | Matthew Holt | |
My goodness that was complicated Blessed be request.Context Sort of | |||
2019-09-03 | Integrate circuit breaker modules with reverse proxy | Matthew Holt | |
2019-09-03 | Some cleanup and godoc | Matthew Holt | |
2019-09-03 | reverse_proxy: Implement active health checks | Matthew Holt | |