summaryrefslogtreecommitdiff
path: root/caddyconfig/httpcaddyfile
diff options
context:
space:
mode:
authorFrancis Lavoie <lavofr@gmail.com>2022-04-25 12:12:10 -0400
committerGitHub <noreply@github.com>2022-04-25 10:12:10 -0600
commit3a1e0dbf47429f3ae7ddcbbd9acc3707b0ad0083 (patch)
tree9851651f43be2d09103a1c76c15430c0ed5e8f6c /caddyconfig/httpcaddyfile
parent77a77c0219d389717ba3b8f8e28bad3462fab655 (diff)
httpcaddyfile: Deprecate paths in site addresses; use zap logs (#4728)
Diffstat (limited to 'caddyconfig/httpcaddyfile')
-rw-r--r--caddyconfig/httpcaddyfile/httptype.go15
1 files changed, 13 insertions, 2 deletions
diff --git a/caddyconfig/httpcaddyfile/httptype.go b/caddyconfig/httpcaddyfile/httptype.go
index f5dd68a..4f9f8d0 100644
--- a/caddyconfig/httpcaddyfile/httptype.go
+++ b/caddyconfig/httpcaddyfile/httptype.go
@@ -17,7 +17,6 @@ package httpcaddyfile
import (
"encoding/json"
"fmt"
- "log"
"reflect"
"regexp"
"sort"
@@ -30,6 +29,7 @@ import (
"github.com/caddyserver/caddy/v2/modules/caddyhttp"
"github.com/caddyserver/caddy/v2/modules/caddypki"
"github.com/caddyserver/caddy/v2/modules/caddytls"
+ "go.uber.org/zap"
)
func init() {
@@ -458,6 +458,17 @@ func (st *ServerType) serversFromPairings(
}
}
+ // Using paths in site addresses is deprecated
+ // See ParseAddress() where parsing should later reject paths
+ // See https://github.com/caddyserver/caddy/pull/4728 for a full explanation
+ for _, sblock := range p.serverBlocks {
+ for _, addr := range sblock.keys {
+ if addr.Path != "" {
+ caddy.Log().Named("caddyfile").Warn("Using a path in a site address is deprecated; please use the 'handle' directive instead", zap.String("address", addr.String()))
+ }
+ }
+ }
+
// sort server blocks by their keys; this is important because
// only the first matching site should be evaluated, and we should
// attempt to match most specific site first (host and path), in
@@ -545,7 +556,7 @@ func (st *ServerType) serversFromPairings(
// emit warnings if user put unspecified IP addresses; they probably want the bind directive
for _, h := range hosts {
if h == "0.0.0.0" || h == "::" {
- log.Printf("[WARNING] Site block has unspecified IP address %s which only matches requests having that Host header; you probably want the 'bind' directive to configure the socket", h)
+ caddy.Log().Named("caddyfile").Warn("Site block has an unspecified IP address which only matches requests having that Host header; you probably want the 'bind' directive to configure the socket", zap.String("address", h))
}
}