From f15f0d5839479f8511621b88fa4bdcca3b89cc32 Mon Sep 17 00:00:00 2001 From: Matthew Holt Date: Sat, 14 Sep 2019 18:05:45 -0600 Subject: Eliminate some TODOs --- modules/caddyhttp/reverseproxy/reverseproxy.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'modules/caddyhttp/reverseproxy') diff --git a/modules/caddyhttp/reverseproxy/reverseproxy.go b/modules/caddyhttp/reverseproxy/reverseproxy.go index 6a7ec70..485d14e 100644 --- a/modules/caddyhttp/reverseproxy/reverseproxy.go +++ b/modules/caddyhttp/reverseproxy/reverseproxy.go @@ -66,7 +66,7 @@ func (h *Handler) Provision(ctx caddy.Context) error { return fmt.Errorf("loading transport module: %s", err) } h.Transport = val.(http.RoundTripper) - h.TransportRaw = nil // allow GC to deallocate - TODO: Does this help? + h.TransportRaw = nil // allow GC to deallocate } if h.LoadBalancing != nil && h.LoadBalancing.SelectionPolicyRaw != nil { val, err := ctx.LoadModuleInline("policy", @@ -76,7 +76,7 @@ func (h *Handler) Provision(ctx caddy.Context) error { return fmt.Errorf("loading load balancing selection module: %s", err) } h.LoadBalancing.SelectionPolicy = val.(Selector) - h.LoadBalancing.SelectionPolicyRaw = nil // allow GC to deallocate - TODO: Does this help? + h.LoadBalancing.SelectionPolicyRaw = nil // allow GC to deallocate } if h.CBRaw != nil { val, err := ctx.LoadModuleInline("type", "http.handlers.reverse_proxy.circuit_breakers", h.CBRaw) @@ -84,7 +84,7 @@ func (h *Handler) Provision(ctx caddy.Context) error { return fmt.Errorf("loading circuit breaker module: %s", err) } h.CB = val.(CircuitBreaker) - h.CBRaw = nil // allow GC to deallocate - TODO: Does this help? + h.CBRaw = nil // allow GC to deallocate } if h.Transport == nil { -- cgit v1.2.3