From 6db3615547b8911ac81dc2b23c1ed8bedbef0fdb Mon Sep 17 00:00:00 2001 From: Matthew Holt Date: Tue, 16 Jun 2020 10:41:37 -0600 Subject: caddyhttp: Enable matching empty query string Caddyfile syntax: query "" Or a nil matcher in the JSON should also match an empty query string. See https://caddy.community/t/v2-match-empty-query/8708?u=matt --- modules/caddyhttp/matchers.go | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) (limited to 'modules/caddyhttp/matchers.go') diff --git a/modules/caddyhttp/matchers.go b/modules/caddyhttp/matchers.go index 5dddb71..6662dac 100644 --- a/modules/caddyhttp/matchers.go +++ b/modules/caddyhttp/matchers.go @@ -349,19 +349,21 @@ func (MatchQuery) CaddyModule() caddy.ModuleInfo { // UnmarshalCaddyfile implements caddyfile.Unmarshaler. func (m *MatchQuery) UnmarshalCaddyfile(d *caddyfile.Dispenser) error { - if *m == nil { - *m = make(map[string][]string) - } - for d.Next() { var query string if !d.Args(&query) { return d.ArgErr() } + if query == "" { + continue + } parts := strings.SplitN(query, "=", 2) if len(parts) != 2 { return d.Errf("malformed query matcher token: %s; must be in param=val format", d.Val()) } + if *m == nil { + *m = make(map[string][]string) + } url.Values(*m).Set(parts[0], parts[1]) if d.NextBlock(0) { return d.Err("malformed query matcher: blocks are not supported") @@ -372,6 +374,9 @@ func (m *MatchQuery) UnmarshalCaddyfile(d *caddyfile.Dispenser) error { // Match returns true if r matches m. func (m MatchQuery) Match(r *http.Request) bool { + if m == nil { + return len(r.URL.Query()) == 0 + } for param, vals := range m { paramVal, found := r.URL.Query()[param] if found { -- cgit v1.2.3