From 04f50a975932c29bf344b45b3444572b449b1faf Mon Sep 17 00:00:00 2001 From: Francis Lavoie Date: Tue, 8 Sep 2020 12:44:58 -0400 Subject: caddyhttp: Wrap http.Server logging with zap (#3668) --- modules/caddyhttp/app.go | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) (limited to 'modules/caddyhttp/app.go') diff --git a/modules/caddyhttp/app.go b/modules/caddyhttp/app.go index 40ae3a2..375ca4d 100644 --- a/modules/caddyhttp/app.go +++ b/modules/caddyhttp/app.go @@ -281,6 +281,12 @@ func (app *App) Validate() error { // Start runs the app. It finishes automatic HTTPS if enabled, // including management of certificates. func (app *App) Start() error { + // get a logger compatible with http.Server + serverLogger, err := zap.NewStdLogAt(app.logger.Named("stdlib"), zap.DebugLevel) + if err != nil { + return fmt.Errorf("failed to set up server logger: %v", err) + } + for srvName, srv := range app.Servers { s := &http.Server{ ReadTimeout: time.Duration(srv.ReadTimeout), @@ -289,6 +295,7 @@ func (app *App) Start() error { IdleTimeout: time.Duration(srv.IdleTimeout), MaxHeaderBytes: srv.MaxHeaderBytes, Handler: srv, + ErrorLog: serverLogger, } // enable h2c if configured @@ -344,6 +351,7 @@ func (app *App) Start() error { Addr: hostport, Handler: srv, TLSConfig: tlsCfg, + ErrorLog: serverLogger, }, } go h3srv.Serve(h3ln) @@ -382,7 +390,7 @@ func (app *App) Start() error { // finish automatic HTTPS by finally beginning // certificate management - err := app.automaticHTTPSPhase2() + err = app.automaticHTTPSPhase2() if err != nil { return fmt.Errorf("finalizing automatic HTTPS: %v", err) } -- cgit v1.2.3