From 3eae6d43b62db96c1d69e82c8d2997b6bf41beda Mon Sep 17 00:00:00 2001 From: Matthew Holt Date: Wed, 3 Apr 2019 11:41:36 -0600 Subject: Add Validator interface Modules can now verify their own configurations --- modules.go | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) (limited to 'modules.go') diff --git a/modules.go b/modules.go index efd5d4a..46dfbe8 100644 --- a/modules.go +++ b/modules.go @@ -138,6 +138,13 @@ func LoadModule(name string, rawMsg json.RawMessage) (interface{}, error) { return nil, fmt.Errorf("decoding module config: %s: %v", mod.Name, err) } + if validator, ok := val.(Validator); ok { + err := validator.Validate() + if err != nil { + return nil, fmt.Errorf("%s: invalid configuration: %v", mod.Name, err) + } + } + return val, nil } @@ -170,6 +177,15 @@ func LoadModuleInlineName(moduleScope string, raw json.RawMessage) (interface{}, return val, nil } +// Validator is implemented by modules which can verify that their +// configurations are valid. This method will be called after New() +// instantiations of modules (if implemented). Validation should +// always be fast (imperceptible running time) and an error should +// be returned only if the value's configuration is invalid. +type Validator interface { + Validate() error +} + var ( modules = make(map[string]Module) modulesMu sync.Mutex -- cgit v1.2.3