From cbb405f6aaee046c9de9ffb4f07ca824d9eedeb1 Mon Sep 17 00:00:00 2001 From: Matthew Holt Date: Mon, 23 Dec 2019 12:41:05 -0700 Subject: cmd: Eliminate unintended use of cgo This means the stop command can only use the API to stop the instance; no more signaling, unless we find a cgo-free way of doing it. --- cmd/commands.go | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) (limited to 'cmd/commands.go') diff --git a/cmd/commands.go b/cmd/commands.go index a861cdf..971d8d9 100644 --- a/cmd/commands.go +++ b/cmd/commands.go @@ -134,13 +134,9 @@ not quit after printing, and can be useful for troubleshooting.`, Long: ` Stops the background Caddy process as gracefully as possible. -It will first try to use the admin API's /stop endpoint; the address of -this request can be customized using the --address flag if it is not the -default. - -If that fails for any reason, it will attempt to signal the first process -it can find named the same as this one (os.Args[0]). On Windows, such -a stop is forceful because Windows does not have signals.`, +It requires that the admin API is enabled and accessible, since it will +use the API's /stop endpoint. The address of this request can be +customized using the --address flag if it is not the default.`, Flags: func() *flag.FlagSet { fs := flag.NewFlagSet("stop", flag.ExitOnError) fs.String("address", "", "The address to use to reach the admin API endpoint, if not the default") -- cgit v1.2.3