From bbe366316771ea23381a473a528e71a72a7148a5 Mon Sep 17 00:00:00 2001 From: Chris Lahaye Date: Mon, 24 Oct 2022 19:58:30 +0200 Subject: caddyconfig: Fix httploader leak from unused responses (#5159) fixes #5158 Signed-off-by: Chris Lahaye Signed-off-by: Chris Lahaye --- caddyconfig/httploader.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'caddyconfig') diff --git a/caddyconfig/httploader.go b/caddyconfig/httploader.go index f199219..04dec34 100644 --- a/caddyconfig/httploader.go +++ b/caddyconfig/httploader.go @@ -134,16 +134,16 @@ func doHttpCallWithRetries(ctx caddy.Context, client *http.Client, request *http var err error const maxAttempts = 10 - // attempt up to 10 times for i := 0; i < maxAttempts; i++ { resp, err = attemptHttpCall(client, request) if err != nil && i < maxAttempts-1 { - // wait 500ms before reattempting, or until context is done select { case <-time.After(time.Millisecond * 500): case <-ctx.Done(): return resp, ctx.Err() } + } else { + break } } -- cgit v1.2.3