From 1b061815b2a336ce4f8d1d3ce3054dab19e00745 Mon Sep 17 00:00:00 2001 From: Matthew Holt Date: Wed, 22 Apr 2020 19:57:06 -0600 Subject: reverseproxy: Don't forget to provision embedded headers handler https://caddy.community/t/set-cookie-manipulation-in-reverse-proxy/7666?u=matt --- modules/caddyhttp/reverseproxy/reverseproxy.go | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/modules/caddyhttp/reverseproxy/reverseproxy.go b/modules/caddyhttp/reverseproxy/reverseproxy.go index e322a74..9e0f636 100644 --- a/modules/caddyhttp/reverseproxy/reverseproxy.go +++ b/modules/caddyhttp/reverseproxy/reverseproxy.go @@ -135,6 +135,16 @@ func (h *Handler) Provision(ctx caddy.Context) error { h.CB = mod.(CircuitBreaker) } + // ensure any embedded headers handler module gets provisioned + // (see https://caddy.community/t/set-cookie-manipulation-in-reverse-proxy/7666?u=matt + // for what happens if we forget to provision it) + if h.Headers != nil { + err := h.Headers.Provision(ctx) + if err != nil { + return fmt.Errorf("provisioning embedded headers handler: %v", err) + } + } + // set up transport if h.Transport == nil { t := &HTTPTransport{ -- cgit v1.2.3